Ewoud Kohl van Wijngaarden

Results 1159 comments of Ewoud Kohl van Wijngaarden

I think because of this line Puppet won't switch modules: https://github.com/voxpupuli/puppet-redis/blob/cfa21daf10a11bbd40aafd409cffc39b2babe2f7/manifests/dnfmodule.pp#L15

> I don't know if Debian/Ubuntu can do the same so for now I've set it only for RH-8. https://wiki.debian.org/CryptoPolicy suggests that it was mostly RH patches but update-crypto-policies is...

Turns out it's `PROFILE=SYSTEM`, not PROFILE=system`. See https://github.com/puppetlabs/puppetlabs-apache/pull/2336#issuecomment-1292232421 as well.

Looks like I did miss some things, but don't have time to look into it now.

I would probably take this example: https://github.com/puppetlabs/puppetlabs-apache/blob/77255d652212466ae5dbc81b1381936794c50dbf/spec/defines/vhost_spec.rb#L1723-L1736 Then copy it and pass some parameters that triggers the behavior you want to test. Note you can also test the whole file:...

I think the only option is to use Hiera: ```puppet include apache include apache::mod::php ``` Then use Hiera: ```yaml apache::mpm_module: prefork apache::mod::prefork::maxspareservers: 20 ```

Could you come up with a patch?

Pushed a trivial rebase, no changes.

Looks like I'll need to update the tests to match the expected values.

Includes https://github.com/puppetlabs/puppetlabs-apache/pull/2335 since EL8+ sets `SSLProxyCipherSuite` by default.