puppetlabs-java icon indicating copy to clipboard operation
puppetlabs-java copied to clipboard

Simpify logic

Open ekohl opened this issue 1 year ago • 2 comments

I'll admit I didn't run the tests and rely on CI, but I think this results in the same values. Just easier to read.

ekohl avatar Sep 16 '22 15:09 ekohl

Look's like an error with the brackets:

---> syntax:manifests
Could not parse for environment *root*: Syntax error at '}' (file: /home/runner/work/puppetlabs-java/puppetlabs-java/manifests/init.pp, line: 62, column: 5)

Do like the update though

david22swan avatar Sep 21 '22 08:09 david22swan

Looks like I did miss some things, but don't have time to look into it now.

ekohl avatar Sep 21 '22 16:09 ekohl

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

github-actions[bot] avatar Nov 21 '22 02:11 github-actions[bot]