Ewoud Kohl van Wijngaarden

Results 1159 comments of Ewoud Kohl van Wijngaarden

Thanks for the info @M4rtinK! We discussed this and @stejskalleos will look at this further when he comes back from PTO.

https://github.com/theforeman/foreman/pull/9425 was merged.

I think this relies on fixing these: > [2022-08-25T10:39:01.172Z] ActiveSupport::DeprecationException: DEPRECATION WARNING: Initialization autoloaded the constants Net::Validations, SettingRegistry, HiddenValue, SettingPresenter, Foreman::Deprecation, SettingSelectCollection, MediumProviders, MediumProviders::Provider, MediumProviders::Default, and Foreman::TelemetryHelper. That is also...

I at least opened https://github.com/theforeman/foreman/pull/9418 to see if version 3 works.

I imagined it'd be similar to GH actions where triggers can be an array or a hash: https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-events-to-trigger-workflows Normally I'm not a big fan of that style of programming, but...

> I could add a very basic `README.md` for the role if that is what we need to get it merged. The lack of documentation in this project is a...

This does require https://github.com/theforeman/jenkins-jobs/pull/266 as well, right?

I can follow @evgeni's reasoning what `fqcn-builtins` is a very strict rule with minimal benefit. Have you considered disabling the lint rule instead?

This is probably because they increased version numbers to longer strings. We should really convert it to a structured fact.