forklift icon indicating copy to clipboard operation
forklift copied to clipboard

Add an inherit_kerberos role

Open wbclark opened this issue 1 year ago • 5 comments

The role installs kerberos client packages and optionally copies the configuration and credential cache from the host machine.

wbclark avatar Sep 05 '22 05:09 wbclark

I've rewritten this to use the when: pathname is defined pattern

wbclark avatar Sep 05 '22 14:09 wbclark

Added some minor comments. Would be cool if there would be a few lines in the readme, how to use this role?

evgeni avatar Sep 06 '22 07:09 evgeni

@evgeni some additional context --

The goal of these efforts is to create a portable hotfix environment which is fully encoded in a block of yaml so that other developers can simply copy & paste the box, edit as needed, and vagrant up

I could add a very basic README.md for the role if that is what we need to get it merged. The lack of documentation in this project is a real concern. If we do not also follow through on documenting the other roles then I am not sure whether it is worth documenting this one, and I don't have tons of time to devote to that larger effort at present.

What do you think?

wbclark avatar Sep 06 '22 15:09 wbclark

I could add a very basic README.md for the role if that is what we need to get it merged. The lack of documentation in this project is a real concern. If we do not also follow through on documenting the other roles then I am not sure whether it is worth documenting this one, and I don't have tons of time to devote to that larger effort at present.

I think a policy where we document new roles is a good start.

On a related matter I opened https://github.com/theforeman/forklift/pull/1568. It doesn't document the ansible roles, but that could be a nice addition.

ekohl avatar Sep 06 '22 16:09 ekohl

I agree that the roles are under-documented, even if most roles are not designed to be used on their own, but are rather abstractions most users shouldn't have to care about.

If you say these are building blocks, and you will provide the "full" workflow later, I am cool with adding the docs for that feature later too.

evgeni avatar Sep 06 '22 17:09 evgeni