puppetlabs
Only require password when used
If the if in line 39 evaluates to false, the user has been created
elsewhere, and we don't actually use (and thus need) password in
postgresql::server::db class.
postgresql::server::db is a type
Breaking changes to this file WILL impact these 37 modules (exact match):
- nicopaez-dockerserver
- jmkeyes-razor
- jjulien-trac
- atmesh-deploy_railsapp
- landcareresearch-pidservice
- driebit-zotonic
- eschiller-trac
- nnutter-testdb
- katello-gutterball
- nicopaez-alfred
- nicopaez-triage
- saw-reviewboard
- mjhas-mailserver
- Ginja-puppet_stack
- urgi-galaxy_roles_profiles
- hetzner-roundcube
- mukaibot-bamboo
- aursu-gitlabinstall
- opuscodium-taiga
- sensson-powerdns
- johanek-redmine
- npwalker-pe_external_postgresql
- adullact-demarchessimplifiees
- puppetfinland-puppetmaster
- zleslie-bacula
- sensu-sensu
- theforeman-pulpcore
- treydock-keycloak
- puppet-zabbix
- SchnWalter-happydev
- groupbuddies-gb
- blackknight36-bacula
- openstack-openstacklib
- puppetlabs-puppetdb
- wdijkerman-zabbix
- theforeman-foreman
- katello-candlepin
Breaking changes to this file MAY impact these 20 modules (near match):
- jmkeyes-netbox
- Firebladee-moodle
- example42-psick_profile
- jortencio-superset
- simp-foreman
- sebastianrakel-gitea
- tedivm-hieratic
- Lavaburn-razor
- example42-psick
- cesnet-oozie
- maestrodev-maestro_demo
- maestrodev-maestro_nodes
- puppetfinland-patchwork
- Lavaburn-cabot
- ash-netbox
- icinga-icinga
- cleo-harmony
- echoes-wrappers
- cesnet-hive
- soli-wrappers
This module is declared in 70 of 579 indexed public Puppetfiles.
These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.
Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.
![puppet-community-rangefinder[bot] avatar](https://avatars.githubusercontent.com/in/22507?v=4 "Published by a pub.dev verified publisher"){kind=small}
Well the major use case from my end is "this is how we happen to use it, and it stopped working when https://github.com/puppetlabs/puppetlabs-postgresql/commit/d878d13f030cdd872cbb04c43ad0f065fec0b923#diff-09acae987abfb6f2de2796ebbbcee8911d8326cf762451972538f4f78984f35c was introduced".
Before that commit setting it to undef was fine, but afterwards not anymore.
Looking just at the code in this class, without taking global context into perspective this solution kind of makes sense. "Why require data when it's not actually used or needed for this class".
Oh, and right now, as a workaround, we're passing around password: 'unused' in hiera, since the value gets ignored anyway, so I feel solving this in the code is a bit more elegant :)
