Erik Kluzek

Results 1353 comments of Erik Kluzek

I did a quick skim over this and this looks good to me. I'll rebase this PR to go to b4b-dev, which should be fine without any trouble. Sometimes you...

Adding next to talk about who will shepherd this in.

We talked about this and will bring it in on b4b-dev.

We have baseline tests for this case that have been passing for us. And I tried the case in the exact branch tag, and it worked as well. SMS_Ln9.ne0CONUSne30x8_ne0CONUSne30x8_mt12.IHistClm60Sp.derecho_intel.clm-clm60cam7LndTuningMode_2013Start--clm-nofireemis Comparing...

> I've incorporated the CFORCE dataset into the datm for testing. And done a one month SP test run. The forcing fields look provisionally ok in a gross sense, except...

@mvdebolskiy @rosiealice @rgknox can you comment on the status of this one? I know @mariuslam is gone, but is there someone else that can bring this in without him? It's...

Cool, thanks for making this a PR @djk2120. It's helpful to start to look through the code. I can tell that I'll need you to do a run-through of the...

This is the only test we have for mimics_matrixcn. It's also possible that the tests that passed would fail if run out far enough.

Here's the note about this test when it was added. https://github.com/ESCOMP/CTSM/pull/640#issuecomment-1074302305 I'm also doing some longer and different tests in ctsm5.2.028 to see the test just happened to pass since...

Longer tests and tests at f10 in ctsm5.2.028 seem to be fine. SMS_D.1x1_brazil.I1850Clm60BgcCrop.derecho_intel.clm-mimics_matrixcn SMS_D.f10_f10_mg37.I1850Clm60BgcCrop.derecho_intel.clm-mimics_matrixcn SMS_D_Lm1.1x1_brazil.I1850Clm60BgcCrop.derecho_gnu.clm-mimics_matrixcn SMS_Ly2.1x1_brazil.I1850Clm60BgcCrop.derecho_gnu.clm-mimics_matrixcn So maybe there is something specific about this with ctsm5.3.0 datasets. We'll mark this...