CTSM icon indicating copy to clipboard operation
CTSM copied to clipboard

Move nml parameters

Open swensosc opened this issue 4 months ago • 4 comments

Description of changes

move namelist parameters to parameter file. parameters moved are: baseflow_scalar, precip_repartition_nonglc_all_rain_t, precip_repartition_nonglc_all_snow_t, precip_repartition_glc_all_rain_t, precip_repartition_glc_all_snow_t

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Yes

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: Will run aux_clm to move to b4b-dev

swensosc avatar Aug 07 '25 14:08 swensosc

I did a quick skim over this and this looks good to me. I'll rebase this PR to go to b4b-dev, which should be fine without any trouble. Sometimes you have to rebase the branch when that's done, but I don't expect that now.

The one thing noticeably missing is an updated parameter file with the parameters moved to it.

ekluzek avatar Aug 07 '25 15:08 ekluzek

Adding next to talk about who will shepherd this in.

ekluzek avatar Aug 07 '25 15:08 ekluzek

parameter file location: /fs/cgd/csm/inputdata/lnd/clm2/paramdata/ctsm5.3.041.Nfix_params.v13.c250221_upplim250_add_nml.nc

swensosc avatar Aug 07 '25 20:08 swensosc

We talked about this and will bring it in on b4b-dev.

ekluzek avatar Sep 12 '25 20:09 ekluzek

Paused testing because need to bring the new params (see post above) to the latest paramfiles:

OK ./build-namelist_test.pl
./run_sys_tests -s aux_clm -c ctsm5.4.001 --skip-generate
./run_sys_tests -s aux_clm -c ctsm5.4.001 --skip-generate --skip-git-status

slevis-lmwg avatar Dec 15 '25 19:12 slevis-lmwg

Before I add the new params to paramfiles:

  • [x] list the latest paramfiles on master and b4b-dev master currently ctsm5.4.004 has the latest and Erik tells me that we do not expect other paramfile updates:
<paramfile phys="clm6_0" >lnd/clm2/paramdata/ctsm60_params.c251211.nc</paramfile>
<paramfile phys="clm5_0" >lnd/clm2/paramdata/clm50_params.c250311.nc</paramfile>
<paramfile phys="clm4_5" >lnd/clm2/paramdata/clm45_params.c250311.nc</paramfile>

ctsm60 and clm50 are the paramfiles to update, not clm45.

Consider the new tool in #3622 if needed.

slevis-lmwg avatar Dec 15 '25 20:12 slevis-lmwg