ejfdickinson
ejfdickinson
Thanks @MarcBerliner !
@rtimms For our use cases, a maximum duration would be fine, so long as it's declared on simulation exit like a `"Time"` stop rather than occurring silently. As noted in...
@rtimms Off-topic I know, but for this reason I find it odd that `calc_esoh=True` is the default in `pybamm.Simulation.solve()`.
To add - although the repeat uses default numerical settings, I've done my best to exclude numerical error as a source for the discrepancy, which appears to be roughly mesh-independent...
@rtimms Thanks for the further analysis! So, for the record - `pybamm.lithium_ion.SPMe` does _not_ implement Marquis 2019, and irrespective of anything else, there's a flat documentation bug in the claim...
Thanks @brosaplanella - the thermal effects are worth having!
linking discussion on possible fix in #4274