ejfdickinson

Results 37 comments of ejfdickinson

I don't completely know enough about PyBaMM's architecture to know the difficulties of arbitrary funtional input for $\gamma$ once this parameter is exposed in the form I wrote it. At...

@rtimms @mleot I guess in the first instance we would expect this to be parameterised depending on lithiation extent (cs / csmax) and temperature, like diffusivity is. Anything more would...

I would recommend that @mleot continues actual development of this class (if he is willing!), but I would be happy to assist with code review and testing.

@rtimms I'll look over it. Relating to #4884 incomplete items currently excluded from the PR: - If the breaking change to introduce a reference value is unappetising (fair enough), I...

@MarkV-ADI In relation to the BPX issue, you can't write in new fields in this part of the BPX file or it will be rejected by the schema. The schema...

@rtimms Looks good. I think we should try to find a formulation here that enables us to also solve #3867 in a general way. Specifically, in terms of $h$, how...

That makes sense to me. Could we make the former parameter optional and compute it as the mean of the two branches if unspecified, so that the breaking change arises...

@jaskiratsingh2000 That's the basic idea. When it comes to practical implementation, there are some small items and some more substantial challenges though: - Control scientific notation and rounding in the...

@rtimms @tinosulzer Please see code here: [bpx_out.py](https://github.com/ejfdickinson/pybamm-write-to-bpx-dev/blob/develop/pybamm/parameters/bpx_out.py) [Demo notebook](https://github.com/ejfdickinson/pybamm-write-to-bpx-dev/blob/develop/pybamm/parameters/write_to_bpx_demo.ipynb) @jaskiratsingh2000 If you can support the core team, please liaise with them! At this stage I think it's better to take...

@agriyakhetarpal Yes, it is. v24.1 does not do this, so it should be in your release notes for v24.5rc0. Any recommendations on how to work around?