ejfdickinson

@kawaMANMI Thanks for the note. The issue I raised is that the equation at the very top of that note (physical interpretation: "the voltage of a cell is given by...

Perhaps another way of thinking of it is: - the cell voltage is always the difference of current collector potentials (from physical common sense) - but in an asymptotically derived...

@tinosulzer Could you clarify what model `pybamm.lithium_ion.SPMe` actually implements? Is it the canonical SPMe in eqs [40] of Marquis 2019? If so, should I interpret your explanation as being that...

Thanks @tinosulzer - I'll try to find time to look closely next week, and get back to you if I still feel there are unresolved issues. As a practical follow-up,...

Yes @rtimms, I think that would be a good approach to allow sufficient user control, and maybe a judicious default.

I'd widen the one relating to "experiment steps" to make clear that it feels like bad practice to give detailed documentation for a constructor `pybamm.step._Step()` that is not supposed to...

Generally make clear where classes implement `__getitem__` and/or `__setitem__` and so these are the expected calling patterns. Especially, make explicit that `pybamm.Solution` implements a dict of `pybamm.ProcessedVariable` instances, so that...

`pybamm.ProcessedVariable` documents the public attribute `data` as "the same as `entries`" but doesn't document `entries`.

@tinosulzer Yes in principle, but can you suggest what the time commitment and overall working period would be? My suggestions are all provoked empirically by using the library for different...

I think that here the best development would be disentangling the parameterisation of the electrical model (relation of cell current to 1D macroscopic current density) from any parameterisation of the...