Eric Cheng
Eric Cheng
> There are some prices that are like 1.20€ like a serving of ice. Also, when you convert a price from one currency to another, you often get something like...
> While this is an improvement, these prices still don't seem to be that realistic for a typical e-commerce site. > > ``` > faker.helpers.multiple(x=>faker.commerce.price(), {count:100}) > [ > '820.09',...
> The last two decimal digits or the last two significant digits? I would think decimal digits, but I'm open to significant digits as well.
> How about changing how the method is implemented. > > ```ts > const suffix: number = switch ...; > const random = faker.number.float(..., 1/10**(dec-1)) + suffix / 10 **...
> @import-brain Could you please update this PR or should we take it over? @ST-DDT Could you please take this over?
> I also noticed, that the [file](https://github.com/faker-js/faker/blob/next/src/locales/hu/word/noun.ts?rgh-link-date=2023-12-11T18%3A52%3A46Z#L10620) is huge with 10620 lines. We should reduce that to 1000 entries (not sure though whether it should be in a separate PR...
> i would call things like force, pressure, area "quantities" [en.wikipedia.org/wiki/Physical_quantity](https://en.wikipedia.org/wiki/Physical_quantity) - the notation is just the symbol. I agree with this--- "notation" is too similar to "unit", so if...
> Question: Is this normal? When re-requesting review it only allows to re-request from one reviewer. If normal, we should document that behaviour, if not, maybe fix it? > >...
> Checklist from my side: > > Module State > Animal ✅ > Color ✅ > Commerce ✅ > Company > * `bs` should probably be deprecated > * `bsAdjective`...
@Shinigami92 Should this be v6.2 or v7? I'm leaning towards v7, but I'll let you make the final decision