Eric Cheng

Results 81 comments of Eric Cheng

Could we use [the `sanitize-html` npm package](https://www.npmjs.com/package/sanitize-html)?

> This is literally what we have used before: > > https://github.com/faker-js/faker/blob/51a88634092dbe17985e434572385af4e99d1022/scripts/apidoc/signature.ts#L65-L76 My bad, I skipped over the commented block. I just tried uncommenting the sanitizing code and the options...

> @faker-js/members @faker-js/maintainers: As per @Shinigami92's request: Should we have `faker.zodiac.sign(birthday)` as option or is that too much of a utility method. (We would still have `faker.zodiac.sign()`) Hmm, I don't...

> Maybe instead of regex use the related validator.js methods in compination with satisfy? I didn't use satisfy directly, but I think my method also works with the validator.js functions....

> Hey guys, I would like to try to contribute with this feature. Could you assign to me? Not too sure if this feature request is accepted yet, it's been...

> Where would we put this information optimally? > > > > `CONTRIBUTING.md` or our docs? Perhaps both places?

Perhaps, we could add it here? https://github.com/faker-js/faker/blob/main/CONTRIBUTING.md

> What options could be provided for this method? > > I was thinking about: > > ## format > Type: `'basic' | 'DUNS+4'` Default: `'basic'` Description: Defines the results...

> Hi @import-brain. > > Can I work on this if anyone isn’t working on it?, and is there a proposed implementation? Sure! I don't believe there is a proposed...

> Not sure about the name: maybe reverse domain name? Also this should not use random.word instead t should use internet.domainWord() They are usually just called [bundle IDs](https://cocoacasts.com/what-are-app-ids-and-bundle-identifiers/#:~:text=A%20bundle%20ID%20or%20bundle,choosing%20an%20application's%20bundle%20identifier.), lingo-wise. I've...