Eric Huss

Results 755 comments of Eric Huss

One drawback that I think would be good to include is the risk around having publicly exposed shared types be incompatible if a dependency is built multiple times. For example:...

Sorry, this kind of fell of my plate. Process-wise, instead of amending RFCs, this should probably be done as a PR to update the documentation at https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/symbol-mangling/v0.md. However, I think...

Thank you for responding. For me, it helps to explicitly write down reasons why alternatives are not chosen so that they don't remain as tribal knowledge. For example, I had...

One concern about *not* being in the index is that future changes like https://github.com/rust-lang/cargo/issues/4316 would be more difficult (not a blocker, just something to note). It might be worth adding...

> it's more intuitive to assign dependencies to these directly rather than defining optional dependencies, features, and then required features for each artifact. To be clear, I wasn't advocating doing...

> Permissions should only be given to teams within the Rust-Lang organization, not to individuals. This statement is a little confusing to me, can you clarify it? On its own,...

Ah, thanks for the clarification. I'm still a bit uncertain. Will this mean new GitHub teams will need to be created for all the repositories that currently use individual permissions?...

@rust-lang/leadership-council, I have made some significant edits to this RFC to try to bring it up-to-date and ready to merge. A significant change is to drop the requirement that org...

cc @Kobzol Just FYI, I'm not sure if you have seen this, since you have been doing a lot of the work to clean this up.

Thanks! I have not tested this, but seems like it should work. @bors r+