Eero Vaher comments

Results 271 comments of


                                            Eero Vaher

Make it easier to change Gaia row limit

> Do you recall any reasons why the `async_to_sync` decorator wasn't used? There already is an issue about this: #2100.

Make it easier to change Gaia row limit

I noticed that `astroquery` defines a `MaxResultsWarning`: https://github.com/astropy/astroquery/blob/c29328b32832a8fb53371e35ec6d1cb6b3a03470/astroquery/exceptions.py#L93-L97 This is more appropriate for letting the users know their row limit might be too small, so I've updated the pull request.

Update handling configuration items in template

Does this pull request need a change log entry or has the `no-changelog-entry-needed` label been forgotten?

Update handling configuration items in template

I have added a section to the opening post that explains the motivation for the changes this pull request proposes.

Fix changing `simbad` config items at runtime

I had to rebase to solve a conflict in the change log.

Fix changing `simbad` config items at runtime

I had to rebase again to resolve another merge conflict in the change log. I also decided to add a `_row_limit` property that works analogously to the other two I...

Fix changing `simbad` config items at runtime

I have rebased the commits to update the change log entry.

Fix changing `simbad` config items at runtime

For some reason none of the tests ran at all. Should I rebase again to start the tests?

Fix changing `simbad` config items at runtime

I've updated the pull request so that the documentation about the Simbad subpackage is kept up to date regarding the configuration, and I had to rebase to resolve a merge...

Fix changing `simbad` config items at runtime

I had to rebase to fix a merge conflict in the change log, again.