Eero Vaher

Results 271 comments of Eero Vaher

Quite a few functions have been deprecated already. The ones deprecated long enough time ago would be simple to remove as long as there is an agreement about how long...

The attribute name getting modified like that is the result of [name mangling](https://docs.python.org/3/tutorial/classes.html#private-variables). The `__appendData()` method is defined in the `Tap` class, so it can be accessed as `_Tap__appendData()`.

It is not obvious to me that overwriting `search_async_jobs()` would be the best solution. I would say the problem is that `__appendData()` is defined in `Tap`, but only used in...

`git grep appendData` finds two matches in all of `astroquery`. One of them is the method definition in `Tap`, the other is included in your traceback. Moving the method to...

The `__init__()` file defines the default value for the configuration item. The [configuration file](https://astroquery.readthedocs.io/en/latest/configuration.html) does contain a section for `mast`, and setting the `timeout` item in that file takes precedence...

Wouldn't it be better to delay this until a decision about the `black` APE is made? I don't see why it would be a good idea to manually apply code...

Even if manual fixes cannot be avoided entirely, wouldn't it still be less work to apply them after `black` has been adopted?

sphinx-doc/sphinx@7318d1dfd4ba39d9aa74f718bb02fba2ded9648f introduced code to `sphinx` 3.5 that ended up being incompatible with Python 3.10. The fix was provided by sphinx-doc/sphinx@8b2031c747e7c7e6b845ee2e3db47de617d33cc6, but is available only for `sphinx` >= 4.2. Installing `astropy[docs]`...

For the time being I have installed `sphinx` 3.4.3. This does not address the underlying problems, but at least it enables building `astropy` docs with Python 3.10.

It looks like this issue about `table.join()` with `join_skycoord()` is what the warning in https://docs.astropy.org/en/stable/table/operations.html#joining-coordinates-and-custom-join-functions is about. You can get the expected results either by removing rows from the tables...