Eero Vaher

Results 271 comments of Eero Vaher

Do you know when `pytest` is planning to switch to `pyproject.toml`? If it happens soon enough then we could move the configuration directly from `setup.cfg` without going through `tox.ini`.

I would squash the two commits down to one, and then it should be good to merge.

I don't see any point in even considering this while #13735 is still open, and I don't think we should be working on #13735 at all until the decision about...

I had some trouble getting one of the doctests to pass the Windows and 32-bit tests because of a printed dtype, but its sorted out now and this pull request...

I will backport manually. If NumPy says that `default_rng()` is the way to generate random numbers then we shouldn't be telling people otherwise.

`Distance` is a subclass of `units.SpecificTypeQuantity`, so making the physical type of a `Distance` instance be dependent on the arguments it was initialized with would be a major change.

There's a bunch of warnings like this: ``` /home/docs/checkouts/readthedocs.org/user_builds/astropy/envs/12926/lib/python3.9/site-packages/astropy/modeling/functional_models.py:docstring of astropy.modeling.functional_models.AiryDisk2D:1: WARNING: py:class reference target not found: astropy.modeling.mixins.AmplitudeReturnUnitMixin ``` It looks like `docs/modeling/reference_api.rst` needs to be updated.

I am unable to replicate the problem locally, so I'll have to test possible solutions by pushing here. If it works then I'll open a separate pull request.

The tests are still failing, but this time with a different error message: ``` py310-test-cov run-test: commands[1] | pytest --pyargs astropy /home/runner/work/astropy/astropy/docs --cov astropy --cov-config=/home/runner/work/astropy/astropy/setup.cfg ImportError while loading conftest '/home/runner/work/astropy/astropy/conftest.py'....

The comments seem to indicate that the code that would be replaced is overly complicated because of backwards compatibility with Python 2, and the fact that this pull request passes...