Edgar Garcia

Results 16 comments of Edgar Garcia

Large deployment pipelines with multiple children results in huge pipeline body

@xibz I agreed with it. I am not sure why this issue was closed as part of my PR merged but although we store trigger in a more effective way...

FR: Spinnaker Supports New GCE Instance Template Fields

@chuanzhenwu I am evaluating the changes required to support instance templates for GCE but Can you summarize the features you would like to see included in Spinnaker for the instance...

FR: Spinnaker Supports New GCE Instance Template Fields

Closing the issue as Resource Manager Tags & Partner Metadata were added to Deck-ui and Clouddriver. These features will be released in 1.36.0

feat(gce): support resourceManagerTags in instance template

I published a snapshot version of these changes to upgrade clouddriver and verify everything works as expected

feat(gce): support resourceManagerTags in instance template

I tested with clouddriver and I only see the `JacksonFactory` does not exist. I am using GsonFactory as fix but I will check other services as well

refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable

I published and deployed a snapshot version with my refactor and I validated a GCE deploy worked as expected. I didn't tests all possible configurations as part of my e2e...

refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable

@Mergifyio refresh

refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable

@Mergifyio rebase

feat(pipelineRef): Replace PipelineTrigger with PipelineRef for Spinnaker UI

I will add more tests around TaskController and endpoints.

feat(pipelineRef): Replace PipelineTrigger with PipelineRef for Spinnaker UI

I added all tests I have in mind for this feature. This is ready now.