clouddriver
clouddriver copied to clipboard
refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable
Key point about the refactor.
- I translated the whole class BasicGoogleDeployHandler into java.
- I split up the handle method into small single responsibility methods.
- I defined unit testing for most of the new methods I created to prove functionality.
- I do not include any new feature or change that was not defined by the BasicGoogleDeployHandler before.
Related to: https://github.com/spinnaker/spinnaker/issues/6985
I published and deployed a snapshot version with my refactor and I validated a GCE deploy worked as expected. I didn't tests all possible configurations as part of my e2e validation.
@Mergifyio refresh
refresh
✅ Pull request refreshed
@Mergifyio rebase
rebase
☑️ Nothing to do
- [ ]
-conflict[📌 rebase requirement] - [X]
-closed[📌 rebase requirement] - [X]
queue-position = -1[📌 rebase requirement] - [X] any of:
- [X]
#commits > 1[📌 rebase requirement] - [X]
#commits-behind > 0[📌 rebase requirement] - [X]
-linear-history[📌 rebase requirement]
- [X]