clouddriver icon indicating copy to clipboard operation
clouddriver copied to clipboard

refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable

Open edgarulg opened this issue 1 year ago • 5 comments

Key point about the refactor.

  1. I translated the whole class BasicGoogleDeployHandler into java.
  2. I split up the handle method into small single responsibility methods.
  3. I defined unit testing for most of the new methods I created to prove functionality.
  4. I do not include any new feature or change that was not defined by the BasicGoogleDeployHandler before.

Related to: https://github.com/spinnaker/spinnaker/issues/6985

edgarulg avatar Oct 10 '24 16:10 edgarulg

I published and deployed a snapshot version with my refactor and I validated a GCE deploy worked as expected. I didn't tests all possible configurations as part of my e2e validation.

edgarulg avatar Oct 10 '24 22:10 edgarulg

@Mergifyio refresh

edgarulg avatar Oct 23 '24 02:10 edgarulg

refresh

✅ Pull request refreshed

mergify[bot] avatar Oct 23 '24 02:10 mergify[bot]

@Mergifyio rebase

edgarulg avatar Oct 23 '24 02:10 edgarulg

rebase

☑️ Nothing to do

  • [ ] -conflict [📌 rebase requirement]
  • [X] -closed [📌 rebase requirement]
  • [X] queue-position = -1 [📌 rebase requirement]
  • [X] any of:
    • [X] #commits > 1 [📌 rebase requirement]
    • [X] #commits-behind > 0 [📌 rebase requirement]
    • [X] -linear-history [📌 rebase requirement]

mergify[bot] avatar Oct 23 '24 02:10 mergify[bot]