Edgar Garcia

Results 16 comments of Edgar Garcia

feat(pipelineRef): Replace PipelineTrigger with PipelineRef for Spinnaker UI

@christosarvanitis Thanks for the review. I tried to put this improvement behind a feature flag to allow for easy disabling or rollback in case of issues. However, since my changes...

feat(pipelineRef): Replace PipelineTrigger with PipelineRef for Spinnaker UI

@dbyron-sf @jasonmcintosh Can I get a review in my PR please?

test(stage): add test to cover scenario when clouddriver returns a failure

@dbyron-sf I removed the AssertionsForClassTypes import and commit your suggested changes. Thanks for the feedback.

test(stage): add test to cover scenario when clouddriver returns a failure

@dbyron-sf I removed the star imports you asked me to remove. FYI

Refactor BasicGoogleDeployHandler in clouddriver

https://github.com/spinnaker/clouddriver/pull/6290

Red/Black Deployments in Spinnaker 1.35.4 not working as expected

@ashleykleynhans @jasonmcintosh I wasn't able to reproduce this issue. I copied the pipeline shared in this issue and adapt it to my spinnaker. I am using Spinnaker 1.35.4. Here is...