Easwar Swaminathan

Results 540 comments of Easwar Swaminathan

Support for multiple stats handler on the client and server was added as part of https://github.com/grpc/grpc-go/pull/5347.

I will circle back to this once the xdsClient API changes are fully merged.

I created a trash bootstrap config with server_uri set to `trafficdirector.googleapis.com:443`, creds set to `insecure` and a project number of `5`. Then I ran the unmodified xds client (which sets...

@ejona86 @dfawley I have a couple of questions here: - Should the client handshake have failed leading to a quick RPC failure? Is that the behavior of the insecure credentials...

> That goes into [a previous conversation](https://github.com/grpc/proposal/blob/master/A57-xds-client-failure-mode-behavior.md?rgh-link-date=2023-02-22T23%3A12%3A07Z#connectivity-status-information-via-ads-stream-failure) about how grpc-go should not be using wait-on-ready for the ADS stream because it can't fail with useful error messages (nor promptly). A57...

After the A57 changes were merged, the client does not time out, and instead throws the following error: ``` 2023/03/02 08:33:51 could not greet: rpc error: code = Unavailable desc...

@chriscasola : Please feel free to send us a PR. But please do keep in mind that old `proto` package is part of some of our APIs, and some of...

> Also, @easwars, I'm interested in knowing which APIs cannot be changed because old proto is part of them. The last time we undertook this exercise, I vaguely remember the...

> The worst thing out of this transition is this part of [channelz/service/service_test.go](https://github.com/grpc/grpc-go/blob/9e1fc3e9c088387890f5a303b805d320f11cc6dd/channelz/service/service_test.go#L276) @dfawley is working on a major rewrite of the `channelz` implementation. He might have some ideas here.

I removed the P3 label so that we track this in our weekly meeting to see if we can make progress.