Easwar Swaminathan

Results 540 comments of Easwar Swaminathan

I agree with @dfawley that moving this out would mean that we would have to make the API stable, and would make future development difficult. But after the generic API...

Blocked on https://github.com/grpc/grpc-go/issues/5818.

FAILED in 1 out of 100000 in google3. Logs: ``` ----------------------------------------------------------------------------- === RUN Test === RUN Test/UpdateAddresses_NoopIfCalledWithSameAddresses [third_party/golang/grpc/internal/grpctest/tlogger.go:116](https://cs.corp.google.com/piper///depot/google3/third_party/golang/grpc/internal/grpctest/tlogger.go?l=116&ws=easwars/6060&snapshot=2): INFO clientconn.go:105 [core] [Channel #1] Channel created (t=+1.374868ms) [third_party/golang/grpc/internal/grpctest/tlogger.go:116](https://cs.corp.google.com/piper///depot/google3/third_party/golang/grpc/internal/grpctest/tlogger.go?l=116&ws=easwars/6060&snapshot=2): INFO clientconn.go:1547 [core]...

Fixed by https://github.com/grpc/grpc-go/pull/5657.

@zasweq : Would you mind running this on google3 once the import is done to see how well this fix addresses the issue, and if we come down to something...

Wohoo !! Thank you all !!

https://github.com/grpc/grpc-go/actions/runs/3709225080/jobs/6287626091 ``` --- FAIL: Test (80.42s) --- FAIL: Test/KeepaliveClientStaysHealthyWithResponsiveServer (4.00s) keepalive_test.go:388: client.NewStream() failed: connection error: desc = "transport is closing" FAIL FAIL google.golang.org/grpc/internal/transport 162.200s ```

https://github.com/grpc/grpc-go/actions/runs/3742909549/jobs/6354439461

https://github.com/grpc/grpc-go/actions/runs/3898035161/jobs/6656341597