Dylan Thacker-Smith
Dylan Thacker-Smith
@daniellaniyo, @Sirupsen please review Fixes #211 ## Problem IdentityCache::MemoizedCacheProxy#delete was assuming the delete failed if cache_fetcher.delete returned falsey. However, that falsey value could either mean the memcached request failed or...
Currently, it is hard to determine where a test should go, since a lot of the test files are organized around overlapping features, resulting in multiple places that could seem...
Currently, IdentityCache::WithoutPrimaryIndex has the following single use internal module includes ```ruby include IdentityCache::BelongsToCaching include IdentityCache::CacheKeyGeneration include IdentityCache::ConfigurationDSL include IdentityCache::QueryAPI include IdentityCache::CacheInvalidation include IdentityCache::ShouldUseCache include ParentModelExpiration ``` This is an anti-pattern...
## Problem It can be hard to get a sense of how wrong the cache normally is (e.g. from cache invalidations being lost due to network issues) or notice when...
This method was initially just used internally to support the `includes` option to `model.fetch_by_id`, where the records had just been loaded, so it seemed like a safe assumption. Rails made...
The `counter_cache` `belongs_to` option is implemented using `update_all`, which is done on the models [update_counters](https://github.com/rails/rails/blob/v5.1.4/activerecord/lib/active_record/counter_cache.rb#L98-L112) and [reset_counters](https://github.com/rails/rails/blob/v5.1.4/activerecord/lib/active_record/counter_cache.rb#L27-L51) class methods. Because these don't trigger an after_commit callback, we end up not...
I noticed in https://github.com/Shopify/identity_cache/pull/360#discussion_r153844042 that this can happen without an exception. There are assumptions in `cache_belongs_to` that I think would lead to inefficient queries and cache corruption.
As mentioned in https://github.com/Shopify/identity_cache/issues/268#issuecomment-250588856 > It looks like we are missing a warning about this in the README and the code. The README even uses ActiveSupport::Cache::MemCacheStore as an example for...
See CI test failures (https://github.com/Shopify/rotoscope/runs/3954967334?check_suite_focus=true) from draft PR https://github.com/Shopify/rotoscope/pull/86 changing CI to test on ruby 3
Blocked on test failures (https://github.com/Shopify/rotoscope/issues/87)