Dylan Thacker-Smith

Avoid null terminated strings in the interface for cgo

2

Here is a script that demonstrates the problem ```go package main import ( "fmt" v8 "rogchap.com/v8go" ) func main() { iso := v8.NewIsolate() ctx := v8.NewContext(iso) val, err := ctx.RunScript(`"before\x00after"`,...

There are a lot of macro use in v8go.cc, making the code harder to read and modify. Specifically, * there are a number of these macros, making it harder to...

As part of #165 we will be changing the V8 precompiled binary more often. Despite removing the windows precompiled binary for now (#234), we have also been adding more precompiled...

Add object for-in support (using v8::Object::GetPropertyNames)

1

This feature request come from a slack question, but seems like something others would want as well [v8::Object::GetPropertyNames](https://v8.github.io/api/head/classv8_1_1Object.html#a27ea564bd46b89d61bfe7b6c8a399c97) documents itself as providing the same behaviour as the for-in statement: >...

Here is an example that shows the problem: ```ruby require 'liquid' template_code =

CI is failing on Rails Edge with the following failure ``` 1) Failure: IndexCacheTest#test_fetch_with_unique_adds_limit_clause [/opt/hostedtoolcache/Ruby/3.0.4/x64/lib/ruby/gems/3.0.0/bundler/gems/rails-18da7b6ba71c/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:589]: unexpected invocation: #.exec_query("SELECT `items`.`id` FROM `items` WHERE `items`.`title` = ? AND `items`.`id` = ? LIMIT...

Update rubocop-shopify to fix CI

1

Rubocop was failing in CI with ``` Error: The `Gemspec/DateAssignment` cop has been removed. Please use `Gemspec/DeprecatedAttributeAssignment` instead. (obsolete configuration found in /opt/hostedtoolcache/Ruby/3.0.4/x64/lib/ruby/gems/3.0.0/gems/rubocop-shopify-2.6.0/rubocop.yml, please update it) ``` So i updated...

CI depends on #518 & #519 Update the version and fill in the changelog for the release

Improve API for "fetch" methods

1

The fetch methods (e.g. `fetch_#{association_name}`) for loading or accessing an already loaded cached record(s) seems inappropriate because 1. It doesn't make it clear to those unfamiliar with this library that...

cc @Larochelle & @Hectorhammett I've started an alternative to https://github.com/Shopify/identity_cache/pull/495 (and the existing `expire_primary_key_cache_index` class method) since I think we need a way to expire caches that doesn't make assumptions...