David Tesar
David Tesar
I'm pretty sure this PR is superseed by #365. Can we close this one @shizhMSFT ?
This is already completed.
As mentioned on the notation call today. As long as we know this works with new directory store with alpha 3 bits, then I'm good to close this as part...
Doing a search on notation repo, there are only two references: 1. https://github.com/notaryproject/notation/blob/135621679e7781c78471ede28a2e419cd228fb68/cmd/notation/registry.go#L5 2. https://github.com/notaryproject/notation/blob/135621679e7781c78471ede28a2e419cd228fb68/pkg/configutil/docker_config_test.go#L13 2 - is in a test, so likely don't need to replace.
We should get better error messages as a result of moving to cobra, but should evaluate the experience of error messages after the PR merges https://github.com/notaryproject/notation/pull/255
Let's also in this improvement make sure the CLIs exit with proper exit code (non zero for failures) https://github.com/urfave/cli/blob/master/docs/v2/manual.md#exit-code
This is a more specific enhancement ask for the inspect command, so transferring implementation to 238.
Should be likely updated here: https://github.com/notaryproject/notation/blob/main/specs/notation-config.md
[Spec ](https://github.com/notaryproject/notation/pull/171/files#diff-4f0565caf9b5f059f3b256722911a83386beb3d5c0dc75b30b6fc91d451e551cR51) needs to be finalized to start on this.
Per some feedback, I'd like to see something implemented such as a `--dry-run` switch on `notation sign` which returns back information about what is going to be signed. This way...