notation icon indicating copy to clipboard operation
notation copied to clipboard

COSE support updates

Open shizhMSFT opened this issue 2 years ago • 1 comments

Tracking the merger of the cose branch into main.

shizhMSFT avatar Aug 12 '22 07:08 shizhMSFT

I will work on this PR.

JeyJeyGao avatar Aug 12 '22 07:08 JeyJeyGao

Codecov Report

Merging #302 (75b256f) into main (8bec8a7) will decrease coverage by 0.08%. The diff coverage is 25.45%.

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   30.62%   30.53%   -0.09%     
==========================================
  Files          25       26       +1     
  Lines        1610     1657      +47     
==========================================
+ Hits          493      506      +13     
- Misses       1104     1138      +34     
  Partials       13       13              
Impacted Files Coverage Δ
cmd/notation/push.go 21.91% <0.00%> (-2.70%) :arrow_down:
cmd/notation/verify.go 17.92% <0.00%> (-1.08%) :arrow_down:
internal/cmd/flags.go 50.00% <0.00%> (-4.55%) :arrow_down:
internal/cmd/options.go 0.00% <0.00%> (ø)
internal/cmd/signer.go 0.00% <0.00%> (ø)
internal/envelope/envelope.go 100.00% <100.00%> (ø)
pkg/configutil/once.go 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 30 '22 02:08 codecov-commenter

I'm pretty sure this PR is superseed by #365. Can we close this one @shizhMSFT ?

dtzar avatar Oct 11 '22 00:10 dtzar

Closing this tracker PR as it is succeeded by #365

shizhMSFT avatar Oct 11 '22 01:10 shizhMSFT