notation icon indicating copy to clipboard operation
notation copied to clipboard

Remove hardcoded reference to "localhost"

Open iamsamirzon opened this issue 2 years ago • 6 comments

Created from #93 to fix hardcoded references to "localhost" to also include 127.0.0.1. Refer one example here. https://github.com/notaryproject/notation/pull/83#discussion_r704681085 .

Desired Resolution

  • Address all hardcoded references to "localhost" by doing a search through all Notation repos.

iamsamirzon avatar Aug 04 '22 15:08 iamsamirzon

Doing a search on notation repo, there are only two references:

  1. https://github.com/notaryproject/notation/blob/135621679e7781c78471ede28a2e419cd228fb68/cmd/notation/registry.go#L5
  2. https://github.com/notaryproject/notation/blob/135621679e7781c78471ede28a2e419cd228fb68/pkg/configutil/docker_config_test.go#L13

2 - is in a test, so likely don't need to replace.

dtzar avatar Aug 05 '22 18:08 dtzar

The original comment is to refactor the following code to a function: https://github.com/notaryproject/notation/blob/4bf25dfacf0239823311e470b702ceb0435a0299/cmd/notation/registry.go#L54

shizhMSFT avatar Aug 25 '22 14:08 shizhMSFT

Discuss with Yi and probably close it if the work is already done

priteshbandi avatar Nov 23 '22 18:11 priteshbandi

The problem still exists. Let's address it in rc.2

yizha1 avatar Dec 02 '22 01:12 yizha1

Only one place in Notation repo: https://github.com/notaryproject/notation/blob/17d3525f5645c9bee69eca6890fccd98780e00eb/cmd/notation/registry.go

yizha1 avatar Apr 26 '23 08:04 yizha1

This issue is stale because it has been opened for 60 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

github-actions[bot] avatar Mar 24 '24 01:03 github-actions[bot]

Issue closed due to no activity in the past 30 days.

github-actions[bot] avatar Apr 24 '24 01:04 github-actions[bot]