notation
notation copied to clipboard
Remove hardcoded reference to "localhost"
Created from #93 to fix hardcoded references to "localhost" to also include 127.0.0.1. Refer one example here. https://github.com/notaryproject/notation/pull/83#discussion_r704681085 .
Desired Resolution
- Address all hardcoded references to "localhost" by doing a search through all Notation repos.
Doing a search on notation repo, there are only two references:
- https://github.com/notaryproject/notation/blob/135621679e7781c78471ede28a2e419cd228fb68/cmd/notation/registry.go#L5
- https://github.com/notaryproject/notation/blob/135621679e7781c78471ede28a2e419cd228fb68/pkg/configutil/docker_config_test.go#L13
2 - is in a test, so likely don't need to replace.
The original comment is to refactor the following code to a function: https://github.com/notaryproject/notation/blob/4bf25dfacf0239823311e470b702ceb0435a0299/cmd/notation/registry.go#L54
Discuss with Yi and probably close it if the work is already done
The problem still exists. Let's address it in rc.2
Only one place in Notation repo: https://github.com/notaryproject/notation/blob/17d3525f5645c9bee69eca6890fccd98780e00eb/cmd/notation/registry.go
This issue is stale because it has been opened for 60 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.
Issue closed due to no activity in the past 30 days.