David Tolnay
David Tolnay
Buildifier works pretty well on BUCK files. `find . -name BUCK | xargs -n1 buildifier -path=BUILD`
I agree with @remysucre that a warning is not necessarily appropriate. I came across the spurious rebuilding behavior described in this issue in the case of https://github.com/rust-lang/crates.io — they have...
We tried out this feature in Syn (https://github.com/dtolnay/syn/pull/734) and decided against using it yet. ## What I am happy with I like how the message turns out at the top...
This is mostly looking good for syn. Filed one bug regarding the rendering of doc cfg on impls of empty traits: #79279.
There are no public impls that would allow you to obtain a `&mut dyn erased_serde::Serializer`, so the original `fn erased_serialize` signature in `Object` can be ruled out. You need to...
Yes, good call! I forgot about `::erase`. It is possible that we could expose a variation of that function where it takes an output location to write either S::Ok or...
This looks similar to #750. We will need to generate something like `rust::Slice` (I think...). - One `const` is the one in `const shared_ptr &` corresponding to your `&SharedPtr`; -...
@else can you point me to an autoconf project that does this correctly?
I would like to understand #1275 before landing any workaround. Was the unreachable_unchecked not actually unreachable? If there is a compiler bug has that been minimized and reported?
> I think this removes some unsafe in a way that ought not affect performance Based on the benchmark in the PR that introduced this code, on my machines this...