David Tolnay
David Tolnay
Integer to float comparisons are hard. In particular, `(i as f64) < f` is not always equal to `i < (f as u64)`. Any ideas for how to implement this?
As discussed in the PR: I am concerned that this would limit our ability to implement arbitrary precision number parsing in the future. In particular, #252 would have wanted to...
That's very impressive! Here is what I saw: https://github.com/serde-rs/json-benchmark/commit/1d4986c2083c8f164f86116f19d70dd32b7519bf.
This needs to be fleshed out a lot more before it can be implemented so please chime in if you have ideas for how this should work. I am glad...
As reported in #1031, unit variants would be nice to support as well. Rust no longer enforces that the value in an attribute is a literal.
Nice, this is on the right track. Regarding the test failure, you can use [cargo-expand](https://github.com/dtolnay/cargo-expand) and the command `cargo expand --test test_macros` in the test_suite directory to see the generated...
That `deserialize_identifier` function is generating the code that identifies which field of a struct or which variant of an enum we are looking at in the input. For example if...
Looks good so far! I tried this against serde_json using the following code, but got an error during deserialization. ```rust extern crate serde; extern crate serde_derive; extern crate serde_json; use...
> Could you tell me where I have to put the unit tests for this feature (I saw that you have `test_de.rs`, `test_ser.rs` and `test_annotations.rs`) ? Where you currently have...
@hcpl would you be able to help get this reviewed and ready to land?