Joe Tsai

Results 341 comments of Joe Tsai

> whether encoding/json v2 with its currently proposed semantics is likely to be the accepted version That I can't really answer unfortunately. We haven't even started the GitHub discussion on...

> It would be very unexpected if repeated calls to Log with the same key `"duplicate"` were to produce output like `{"duplicate": "alpha", "duplicate#01": "bravo", "duplicate#02": "charlie"}`. Possibly, but there...

> Option 2 is pretty clearly the correct choice. That's a matter of opinion. Just as how you find option 3 an odd position, I find option 2 an odd...

> Values passed to a structured logging library necessarily include a key which is, by definition, understood as unique within the target log event By _technical_ definition, I agree. However,...

> Would that be able to detect duplicates in sub-packages though? Depends on the complexity of call-tracking. This is a similar problem as vet checks for `fmt.Sprintf`, which already has...

Another argument against option 2 (which discards data) is security. If untrusted input is able affect what names are present, then that can be used as a mechanism to hide...

@08d2 > There are many additional (and unavoidable) security concerns in a structured logging API beyond this one Like what? The other security issue I can imagine is a DOS...

The [documentation for `google.protobuf.Any.value` says](https://github.com/protocolbuffers/protobuf/blob/54d8f03974c108ef8fd0f26568cd9eb086165568/src/google/protobuf/any.proto#L161): > [The `value` field] must be a valid serialized protocol buffer of the above specified type. Elsewhere, the [documentation for `google.protobuf.Any` says](https://github.com/protocolbuffers/protobuf/blob/54d8f03974c108ef8fd0f26568cd9eb086165568/src/google/protobuf/any.proto#L118-L127): > If the...

> output generated by Go cannot be parsed by the other languages Perhaps I missed it, but the original post only mentioned `protojson.Unmarshal`. Is there a report of whats generated...

Ah, thanks for looking into that. Given the amount of inconsistency in the ecosytem, I suspect every implementation will need to accept both the case where it is preset with...