Joe Tsai

Results 341 comments of Joe Tsai

What's the expected behavior with field extensions?

I don't have any specific concerns, but just trying to remember things that would often bite us later on. Overall this feature sounds fine. It reminds me of @neild's "messagediff"...

Another option: Sell PCIe cards with X number of Edge TPUs on it. The buyer specifies X, you sell a card that matches X, but don't guarantee whether: * it's...

Hi, I have a general sense of the problem your describing, but the solution is sensitive to the exact Go types you're dealing with, could you provide a simple reproduction?

The name collision is unfortunate and [was brought up during the proposal](https://github.com/golang/go/issues/59488#issuecomment-1553882589) for the stdlib "cmp" package. The concern was dismissed as not being a problem: https://github.com/golang/go/issues/59488#issuecomment-1554911781 Adding "go-cmp/cmp" to...

For unexported fields, take a look at https://pkg.go.dev/github.com/google/go-cmp/cmp/cmpopts#IgnoreUnexported. For protobuf types, I highly recommend using https://pkg.go.dev/google.golang.org/protobuf/testing/protocmp#Transform instead.

> 1. Not needing to know the type (just a global option) There's currently no ability to do that and it's unclear that it's a good idea to do that....

This is not specific to `[N]byte` but also `[]byte`. As a point of semantic correctness we have to descend into each individual `byte` element if there were any options that...

Hi, assuming the `searchBudget` is the cause, we can adjust the value a little but not remove it. The search budget is necessary to keep the diffing algorithm as O(N),...

This does seem like a bug in the reporter heuristics in how it determines what context to show. Can you provide a simple reproduction that I can run that reproduces...