Joe Tsai

Results 341 comments of Joe Tsai

Not really. The behavior of `cmp.Diff` is to be symmetric such that the result of `cmp.Equal(x, y)` and `cmp.Equal(y, x)` are identical. Functionally ignoring insertions implies an assymetric comparison, which...

I'm a 👎 to renaming `got` and `want`. See my comment here: https://github.com/google/go-cmp/issues/328#issuecomment-1518120671 I'm a 👍 for only supporting higher versions of Go and using `any` over `interface{}` if @neild...

There's clearly some quadratic behavior (relative to tree depth) going on here, which needs investigation.

Thanks for the concise report and reproduction. This suggest that the reporter should check if the `String()` output of an adjacent difference is identical. If so, to re-format the sub-value...

Hi, thanks for the issue report. It may make sense to provide an option to ignore the `Equal` method. In the mean time you can do something like: ```go type...

I don't think this is going to change. This was discussed in the early days of `cmp` deployment, and people could not agree whether `got` or `want` comes first. People...

For the record, I was in support of `(-got +want)`, but there were a number of notable people on the Go team who instead argued for `(-want +got)`. There are...

When it comes to `cmp.Equal` it doesn't matter since the `cmp` guarantees symmetric property of equality.

Much of the reporter is using a complex set of heuristic to determine how to best format the output. Reports like this and #343 are helpful to adjust the heuristic...

I traced down heuristic for both this issue and #343 to this code snippet: https://github.com/google/go-cmp/blob/master/cmp/internal/diff/diff.go#L112-L120 Changing it to something like: ```go func (r Result) Similar() bool { // Use NumSame+1...