Joe Tsai

Results 341 comments of Joe Tsai

> Using filepath does mean that whether an archive is insecure or not will depend on the platform we're executing on I find that behavior to be fairly surprising. Suppose...

In general, I would not expect `archive/zip` or `archive/tar` to depend on `path/filepath` for anything directly used by the `Reader` or `Writer`. The only OS-specific behavior is isolated within functionality...

Personally, I'm more of a fan of option 1 in https://github.com/golang/go/issues/55356#issuecomment-1256355677. Even though ZIP has its heritage in Windows, and TAR has its heritage in Unix, there's no doubt that...

It's not the behavior I would prefer, but SGTM. As @neild noted in https://github.com/golang/go/issues/55356#issuecomment-1256355677, there just doesn't seem like many good options.

This seems like a duplicate of #43732. > If we add CallInto or something like it, does reflect.Call go down to zero allocations? According to my comment https://github.com/golang/go/issues/43732#issuecomment-761704581, we can...

> Does the CL linked take care of methods? I didn't do anything special for method functions. I'll take a look later if something is needed there.

My concern with this API is that I don't know how I'm suppose to use it. I looked at two use-cases to validate this: * use of `reflect.Value.Call` in "github.com/google/go-cmp"...

Hi @AsterDY, thanks for your proposal. The approaches that `sonic` takes are fascinating. It's nearly impossible to beat the performance of specialized code generated by a JIT since it can...

Merging a JIT into the Go toolchain itself will help alleviate the 4th disadvantage, but it doesn't directly address the 1st, 2nd, or 3rd disadvantages. The 1st disadvantage is the...

Sorry for the drive-by comments, but I was tagged on this :) > Strict compliance with recent JSON-related RFCs For v2 JSON in Go, we're rejecting invalid UTF-8 and duplicate...