Joe Tsai

Results 341 comments of Joe Tsai

The symmetric nature of `cmp.Equal` is a property I don't think we should give up, but I could imagine something like: ```go cmp.Diff(want, got, cmpopts.IgnoreUnpopulated(want)) ``` where `cmptsopts.IgnoreUnpopulated` uses go...

Take a look at https://pkg.go.dev/google.golang.org/protobuf/protoadapt, but you'll need v1.30.0 of the module

Yes, please. When I was working on safe file operations and it turned out to be hard to do correctly without OS support. Without `O_NOFOLLOW`, you have to slowly check...

What, if any, changes would be made to "io/fs"? Ideally, there is a mirror of these APIs in that package.

Hi, thanks for the PR. I'm open to the change, but using environment variables is a distinct change from the fact that everything else is configured through a JSON configuration...

Is there a reason this was a closed? I think it's fairly reasonable.

The fact that values are not always treated as addressable is my biggest regret for the `cmp` package. I wish it had treated all values as addressable. I'm sympathetic to...

A little bit of history: * Enums in protobuf were inspired by C++, where the enum values themselves are in the same namespace as the enum type declaration itself. This...

> How is this binary file (testdata/binary.bin) generated ? I don't remember, but it definitely looks like the compiled output of parts of the Go stdlib. Since the Go toolchain...

> Usage statistics per function would be interesting. If there's a function that isn't used at all, that could be a sign that it's not necessary. @fzipp, scanning the latest...