Dimitrios Siganos

Assert in nano::rocksdb::store::clear()

1

I hit this assert whilst running a unit test. ``` [ RUN ] active_transactions.fork_replacement_tally Assertion (status.ok ()) failed int nano::rocksdb::store::clear(rocksdb::ColumnFamilyHandle*) /home/ds/CLionProjects/work/nano/node/rocksdb/rocksdb.cpp:602 ```

It was proven during a debugging session a few months ago that the election scheduler flush was broken and could return prematurely. It was decided to stop using it and...

block_processor::flush() has a race condition. The problem is that a block can be queued to be signature checked and the signature checker could be inactive and then block processor flush...

Nano node rebroadcasts historical votes while bootstrapping

1

There is a report that a bootstrapping PR rebroadcasts historical nano votes while bootstrapping. We should fix the node to not rebroadcast those votes.

work_pool: move stopping from destructor to stop function

1

The work_pool starts a number of threads and joins them in the destructor. This is pattern we want to break. We want to have a separate stop stage before destruction....

Wanted: to_json() function for nano::block_sideband

3

We currently have no way to convert a block sideband object to json representation for debugging purposes. It would be nice to have that ability. The task is to implement...

Print error info returned by lmdb code instead of just asserting

2

Currently we assert if we receive any kind of error from lmdb, in a number of lmdb related functions. It would be useful to know what kind of error was...

This crash occurred whilst trying to bootstrap from scratch. Git describe: `V26.0DB10-161-g250ed204` ``` Assertion (status == 0) failed nano::store::lmdb::read_transaction_impl::read_transaction_impl(const nano::store::lmdb::env &, nano::store::lmdb::txn_callbacks) /Users/ds/nano/beta/nano-node/nano/store/lmdb/transaction.cpp:43 Assertion (status == 0) failed nano::store::lmdb::read_transaction_impl::read_transaction_impl(const nano::store::lmdb::env...

### Summary The node would drop messages arriving from banned IP addresses. ### What problem would be solved by this feature? It will allow the ability to manually ban some...

The unit test occasionally fails because it expects an election to be dropped once and the election is dropped twice. This might be due to more than one elections starting...