David Sanders
David Sanders
## Description Autolinked references in commit messages of the form `Username/Repository#` are not displayed correctly in the app, but are on GitHub's website. ## Version * GitHub Desktop: 2.1.3 *...
Not going to open a PR for this because I haven't tested it beyond compilation, and not sure it's something you'll want. Switching the code to using `async`/`await` instead of...
Putting 'thread-safe' in quotes because really I'm referring to async code, but the idea is the same. Two different parts of code simultaneously accessing `requestDevice` will lead to a crash:...
For the errors listed in the spec (`InvalidStateError`, `NotFoundError`, etc), these should be `DOMException`s with the name set accordingly. Example: ```javascript throw new DOMException('interface not found', 'NotFoundError'); ``` To make...
#### Description of Change To better support running tests without doing a build. A build generates `electron.d.ts` via the `gn-typescript-definitions` script. Running the `create-typescript-definitions` in `pretest` should ensure the TS...
#### Description of Change Should fix problems running `lint:docs` on Windows at the moment. Backporting broadly as a follow-up PR which builds on this will fix #38024 and touch a...
#### Description of Change `USBDevice` was missing as a possible type for `device`. #### Checklist - [x] PR description included and stakeholders cc'd - [x] relevant documentation, tutorials, templates and...
#### Description of Change This should drop GHA usage of these workflows significantly since the jobs won't need to be started if the conditional is false. Also improves the UX...
#### Description of Change Creates the new version labels when a branch matching `N-x-y` is created and grays out the unsupported labels. This also labels any existing PRs which are...
After poking around and finding several bugs in `lint.js`, here is the current status of the linters as far as I can tell. Making this issue so I can offload...