David Sanders

Usage of Asserts Breaks Code

5

This project uses asserts in a lot of places (I found about 100 cases) where they should **not** be used. They're being used to validate arguments to functions, where the...

chore(plugin-webpack): use trailing slash in dev mode entrypoint baseUrl

2

- [x] I have read the [contribution documentation](https://github.com/electron-userland/electron-forge/blob/master/CONTRIBUTING.md) for this project. - [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate. - [ ]...

Quitting Unsaved Fiddle Should Focus Window

3

Same kind of issue as #1007, it's showing a "Are you sure?" modal but the window isn't focused so the behavior on macOS is trying to quit from the dock...

Improve usage of bulk with Document

7

I know this has been brought up before (#843) but I think it could use a re-visit. The suggested approach of using `to_dict` is starting to become less adequate as...

Permissions Refactor

3

This is a two part suggestion: 1) Use the Django auth backend for permissions. Permissions are already generated for the models in the app (add/change/delete), and you can add new...

Expose Functionality to Clear/Delete Versions From Cache

2

Would be useful if this library exposed functions which could be used to: * Clear the entire cache * Delete specific versions from the cache Since Electron Fiddle uses this...

Transferable?

4

Would be useful if the `ImageCapture` interface was `[Transferable]`, as this would allow offloading grabbing frames from the main thread. Trying to grab frames on the main thread is always...

Clarify grabFrame timing

3

The current implementation of `ImageCapture.grabFrame` in Chromium will always wait for the next frame from the video stream, which was unexpected. The spec doesn't say anything about timing, but I...

onframe Event

2

The current Chromium implementation of `grabFrame` waits until a new frame is available before resolving, which means if `frameRate` is 1, it may take up to 1 second for the...

The current Chromium implementation will reject `grabFrame` for a muted stream, [here's the relevant line](https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/imagecapture/image_capture.cc?l=43). The spec currently says nothing about rejecting on a muted stream. This behavior is problematic...