David Sanders
David Sanders
Closes #183. Opening a PR to get the ball rolling on this, been bit a few times now by this. cc @KyleTryon
`node-install-dir` isn't hooked up to anything, and appears to have never been. It's not documented (beyond automatically as a parameter) or tested. Technically a "breaking change" since it removes a...
Fixes #582. With the changes in #581, a shell is now being used to execute `gn.bat` on Windows and as a result the GN arguments are no longer interpreted correctly...
This is definitely a corner case, but currently prevents this example in the docs from being typed properly: https://github.com/electron/electron/blob/ce4ae584e357000b324228693ed7556922b6335f/docs/api/client-request.md?plain=1#L54-L58 I tried single quotes rather than double quotes with the same...
Example from docs: https://github.com/electron/electron/blob/ce4ae584e357000b324228693ed7556922b6335f/docs/api/app.md?plain=1#L1137-L1141
There's been some cases in the docs where return types are listed as ``Returns `` | `` `` which gets turned into a return type of just ``, and ``...
https://www.electronjs.org/de/docs/latest/tutorial/quick-start Links to `app` and `BrowserWindow` look to be broken only under this translation. 🤔 ``` [WARNING] Docusaurus found broken links! Please check the pages of your site in the...
New additions to "API Structures" on the sidebar aren't alphabetized, which is confusing since the large majority of them are, and the other sections like modules are alphabetized.
@erickzhao, looks like maybe the script that generates additions to the sidebar has a shortcoming here? Didn't expect to find stuff down there at the bottom in a separate grouping....
`heroku-18` reached EOL in April 30, 2023. Should update to use a newer stack. Should merge #49 first to avoid getting bit by that `@octokit/request` bug in the future. https://github.com/electron/sheriff/blob/060fe045b428be52be4f7642490f2b79a5f29dd0/app.json#L77