electron icon indicating copy to clipboard operation
electron copied to clipboard

Some Build Linters Silently Fail

Open dsanders11 opened this issue 5 years ago • 3 comments

After poking around and finding several bugs in lint.js, here is the current status of the linters as far as I can tell. Making this issue so I can offload it from my brain and track the various PRs.

Python Objc Gn Patches JS/TS C/C++
Linux #26253 :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
Windows #26253 :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: ✔️ :heavy_check_mark:

Status:

  • The Python linter doesn't work across the board, needs several fixes to ensure it's working robustly.
  • ~~Objc and C/C++ on Windows mostly work, just cpplint does not. Fix for that incoming shortly.~~
  • ~~JS/TS linting on Windows doesn't work, and requires a more involved fix.~~

dsanders11 avatar Oct 17 '20 01:10 dsanders11

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

github-actions[bot] avatar Oct 07 '22 02:10 github-actions[bot]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

github-actions[bot] avatar Jan 10 '23 02:01 github-actions[bot]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

github-actions[bot] avatar Apr 11 '23 01:04 github-actions[bot]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

github-actions[bot] avatar Aug 03 '23 01:08 github-actions[bot]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!