dario righelli

Results 46 comments of dario righelli
trafficstars

Hi @senbaikang, thanks for the explanation, but maybe, as Lukas suggested, it would be better to write a unit test to verify this aspect before merging into the main branch....

Thanks @EliHei2 for highlighting this at the moment the package depends on this library, so it's not possible to bypass this without installing the library on your machine. Thanks @LTLA...

Hi Lukas (@lmweber), I'm glad you raised this point because I'm also interested in this aspect. I saw the `MoleculeExperiment` and the `SpatialFeatureExperiment` packages, but still, I think it's too...

Hi Ludwig @lgeistlinger , when we designed this class, we only referred to the 10xVisium data, which didn't need any other additional column. Of course, right now there is plenty...

I'm sorry @lgeistlinger, maybe I'm not getting what you mean ... The `imgData` is designed to store images at the moment, so we designed it for storing images and metadata...

okok, thanks for the clarification! :)

I agree with keeping the whole scale factors associated with each image. Since you are working on the SpatialImage, do you want to do this @HelenaLC ?

A possible discussed implementation: create a dedicated element inside the metadata to store the entire `scalefactors_json` values and check them during the `cbind` process across all the samples. Possibly, indexing...

Yes, I also think that the best way is to store them inside the `metadata` by indexing per `sample_id`

Thanks @raysinensis for reporting this issue, we're going to fix this!