Adam Heller
Adam Heller
For posterity: need to establish that these won't be leaked under all scenarios.
@apolcyn I've done the backport. Please manage getting the C# binaries built. Thanks!
+1 to Craig's comment, I just commented a reference on the related issue that explains why: https://github.com/grpc/grpc/issues/37120#issuecomment-2204312257
@d7d1cd Please sign the CLA, and we can move forward.
> What needs to be done to get the changes into the branch? Now that you've signed the CLA, I've started the CI jobs for this PR. If all looks...
Sanity checks have failed due to clang-format problems. See https://btx.cloud.google.com/invocations/122b491b-8891-4604-bf27-4bf4e5fa47c5/targets. I don't seem to have permission to push a change to your branch, so you'll need to get this sorted....
I just noticed that this PR targets the 1.65.x branch. We only develop against `master`, the release branches are used for releases & important backports only. I don't seem to...
@ctiller This is more your domain, I'm curious what you think. gRPC has relied on Abseil for years, and Abseil has had this macro in place for years, but gRPC...
Correction: abseil does maintain a set of namespaced macros (`ABSL_CHECK`, etc) that we should be using everywhere on the gRPC include path. We had one oversight there, and a fix...
Please test with the event_engine_listener experiment enabled, iomgr is being deprecated.