Adam Heller comments

Repositories
Issues
Comments

Results 92 comments of


                                            Adam Heller

A class with a virtual method does not have a virtual destructor

FWIW, we do a fairly strict continuous build with clang, which includes this check. What you're seeing could be a g++ oddity. https://github.com/grpc/grpc/blob/b1c3b5ddfeb69dcb86e2c3afc37a0d82a27ee92e/bazel/copts.bzl#L19-L58

A class with a virtual method does not have a virtual destructor

PR approved, thanks! Please sign the CLA so we can move forward. > I also tried to build the original grpc code from the 1.65.0 tag using the clang compiler,...