AJ Heller

Results 56 comments of AJ Heller

@chamikaramj I believe you're running into a deadlock with Popen using `stdout=subprocess.PIPE`. I confirmed that the gRPC fork handlers aren't running at all when your example hangs, which means this...

> How can I add support for bazel? One potential solution would be to add a config variable that can be toggled with something like `bazel build --define=use_systemd=true`, and introducing...

@abeltranmsft Thanks for this. It seems like this is going to be difficult to wire into our CI environment, IIUC an end2end test would require modifying the system's own systemd...

> the API to get the FD from libsystemd is trivial and exercised in the same way across a gazillion projects That's great. And I understand there is some unit...

@bluca thanks, we restrict CI runs to team members only, intentionally. Letting anyone (new or established Github users) run the CI could easily exhaust our resources, so we keep it...

> About removing the handling from the subchannel code, I have seen code in prod use this test arg unfortunately. I can't think of a better reason to remove it....

In the basics tutorial, https://grpc.io/docs/languages/cpp/basics/, the RouteGuide's `RouteChat` service is a bidirectional streaming RPC. There's an asynchronous callback-based server implementation in https://github.com/grpc/grpc/blob/e026f5759c3f589745b50c0577a1b50f62f558a3/examples/cpp/route_guide/route_guide_callback_server.cc. Hope this helps!

That sounds like a bug in the platform's `netinet/tcp.h` implementation. If it requires `sys/types.h`, it should probably include it. I found a [few](http://fxr.watson.org/fxr/source/netinet/tcp.h) [implementations](https://sites.uclouvain.be/SystInfo/usr/include/netinet/tcp.h.html) that do so.

> making a header reordering tweak is not advisable. I have no objection to getting gRPC working on the platform, the PR looks fine. I'm just calling out the deficiency...