Adam Heller
Adam Heller
Based on the screenshots provided, I believe this is a duplicate of https://github.com/grpc/grpc/issues/29979, regarding a visual studio bug with certain non-English locales. It seems the fix was incomplete, since it...
Thanks for pointing that out, @ctiller. ResetDefaultEventEngine isn't necessary anymore now that gRPC keeps a weak_ptr instead of a raw pointer, so I've removed the function https://github.com/grpc/grpc/pull/31213. To clarify the...
I believe that means this PR is safe to land. Please chime in if you disagree.
Thanks Mark! I like this approach, and I've merged it in. > Also, we don't yet want to allow passing in the EE instance from the application via channel args...
> Looks like you removed the definition of the overload in the .cc file but forgot to remove the declaration here in the .h file. Good catch, removed.
I'm not sure it's possible to remove ads from the site search results. @chalin do you know if we can?
Thank you for this, I've left comments on the PR.
Setting the cache prefs `outgoingCallPrefTitle` and `incomingCallPrefTitle` to false on logout would take care of that. But what do you think about restoring those settings after successful login?
Also, out of curiosity, what's the use case for the Logout button? I can't think of a reason I'd want to use it, but I imagine someone might ...
re: funny business: that was my question, too :) Open source for the win.