Results 379 comments of Chris Brown

While my experience with Passport is limited, the changes you are proposing here so far make sense. (Edit: except that, as **parallels999** has said, the proposed checks are already in...

Still reviewing this. As you say, it's quite substantial.

> Hi, were you able to evaluate for a moment the underlying reasons for this PR? I believe I understand your objective, and am willing to consider it for future...

Would it still work if instead of calling `$permissionRegistrar = static::getPermissionRegistrar();` in multiple functions, it were to be set as a property once when the trait is instantiated?

Hi, Can you test out this fix: https://github.com/spatie/laravel-permission/pull/2582

> Is this still relevant? Yes.

There are no plans to change the migration to accommodate this, as it is very driver-specific. Anyone needing the `timestamps(2)` format can easily update their migration accordingly.

Instead of `$users[0]->hasRole(UserRoleEnum::ADMIN->value)`, does it work if you remove the `-value` part? (because it does that internally)