laravel-permission icon indicating copy to clipboard operation
laravel-permission copied to clipboard

Get permission and role class from method instead of the configuration in traits

Open illambo opened this issue 1 year ago • 3 comments

Edit: I push PR #2623 for a more complete solution.

This PR add the (little) ability to override role and permission model class in traits, this can "facilitate" (in a non-exhaustive manner, see discuss #2571) some cases of applications with package used on multiple databases (without the need to modify the configuration at runtime).

illambo avatar Feb 19 '24 07:02 illambo

Must be the same change for Models?? https://github.com/spatie/laravel-permission/blob/0e593bb9e6808cc55c67f150878b0847f20b9036/src/Models/Permission.php#L61 https://github.com/spatie/laravel-permission/blob/0e593bb9e6808cc55c67f150878b0847f20b9036/src/Models/Role.php#L70

parallels999 avatar Feb 20 '24 16:02 parallels999

Good point, later I check this. Thanks

illambo avatar Feb 20 '24 17:02 illambo

still reviewing this and the other PR

drbyte avatar Apr 19 '24 03:04 drbyte