Chris Brown
Chris Brown
Right. Good points. Yes, should add that test for the 403.
> Wouldn't this (not small) change go against the guidance just posted on the Zen Cart forums: https://www.zen-cart.com/showthread.php?229962-Feedback-on-2-0-0-beta1 If one tried to get it into v2.0.0 release, yes. But there's...
I'm agreeable to 2.1, but not sure who will code this feature or when that will happen, so untagging it for now.
I like the simplicity of the one-line call to import/inject other content into certain places in a template. It's a feature that's been begging for inclusion for some time. Your...
Question: Are there more ways it can be enhanced to make dependence on Define Pages less "required"? Perhaps the `protected outputDefinePage()` could be the "default" output of a `protected renderOutput()`...
Coming up with all the ideal places to build-in these render-hook calls to `insertContent()` is an interesting project in itself. Another benefit of defining (and documenting) a list of built-in...
Many will be tempted to include their own DIV wrapper in whatever they generate to send to the renderhook, so that they can style their bespoke block themselves. So, my...
Interesting discovery. Digging further, I see that it's been that way since at least v1.5.0. And there's no CSS rule defined for it in any core CSS files.
That said, I'm not sure it needs changing, since one can simply combine the two classes into one selector in a CSS file in order to target the combination. ie:...
I took a stab at this, and have pushed a couple PRs: - #6248 that adds an `id` to all `textarea` fields, which makes this easier to target elements properly....