Chris Brown
Chris Brown
Something to keep in mind: - the "main" product image is also the one used for the thumbnail, even if the image itself is higher resolution - the "small" dimensions...
I can't edit the PR or contribute to it due to blocks set against it in your branch. I'll just merge and edit it afterward.
> This can be fixed easily by adding `nullable()` in Lines 62 & 86 of the migration stub. Primary index creation on Lines 65 & 89 will have to be...
Apologies. Yes, you're correct. I eagerly read that migration incorrectly, and conflated the point with something else. There is a long history of it being this way. And by design...
`public` functions can be called from any other class/function/code outside the class as well as from within the class. However, `protected` or `private` functions can only be called from other...
I reverted some of the removals of "unnecessary default parameters", because I'd prefer that they remain for clarity. I also added some strict === checks, and removed leftover unnecessary parentheses.
> can I add hints to this as they are not causing me any trouble in production? You mean declaring the public/protected `type` such as `string`/`int` etc? Yes.
Yes, this change is needed, as you pointed out: ```diff - array_reverse($category_tree); + $category_tree = array_reverse($category_tree); ``` But then the other situations where an "incomplete cPath" is used is curious....
When large numbers of categories exist, parsing complete cPaths for every one in the list can get CPU intensive. I was hoping to avoid that. But I guess I'd need...
In trying to load my brain up on this whole scenario, and replaying back through #4437 and #7124 and #7173, I note that the original "problem" was that `$cInfo` was...