Daniel McCloy

Results 823 comments of Daniel McCloy

this turns out to be a rather deep rabbit hole. IIUC, there's a fundamental difference between how `FunctionSortKey` and the other builtin `*SortKey` classes work: - builtin classes inherit from...

xref to #12857. It would be nice if what was decided there (but never implemented yet) also worked here (or vice-versa) so that we were internally consistent.

> the issue with this was (and still is) a lack of support for `sphinx_theme_builder` on our end. AFAIK no other package requires this, so no one got around to...

I think this should be fixed now by pydata/pydata-sphinx-theme#1264. Hopefully now nobody ever sees that warning unless they actually request a pygments theme that doesn't exist.

> preprocessing/tests/test_fine_cal.py::test_compute_fine_cal is failing in the pipeline, but I don't know how could I broke this one, surprisingly in my machine is failing for kind VectorView, but in the pipeline...

> @drammock https://github.com/mne-tools/mne-python/actions/runs/14239287761/job/39937221292?pr=13156 the old pipeline is still failing, this time however is numpy.typing who is missing, most probably due to an old numpy version, how would you like to...

> @larsoner I took a look at the failing tests, but I don't know the reason they are failing, do you have any clue? > > Thanks! CI errors are...

> if people are not registering on transife using their github account it will be complicated to find back who to add as co-author No knowledge of GitHub username is...

Thanks @melissawm for offering to set it up! My personal bias is that if we can make it fully automated, we should --- I don't trust myself to always remember...

obligatory cross-ref to https://github.com/mne-tools/mne-python/pull/12450#issuecomment-1967238036, in particular > If the desired end-state here is "cleaner separation of concerns" / "pybv only handles brainvision stuff, not MNE stuff" then I think there's...