Daniel McCloy
Daniel McCloy
This is looking really good. Is it easy to make the API entries and the example/tutorial files to have different shapes and colors? Like blue ellipses for API and yellow...
+1 for dumping a config summary file with some indication of which params were user-set and which were defaults. I don't think the summary needs to be re-usable, necessarily (it...
@moritz-gerster see WIP #296 and discussion there
see https://github.com/mne-tools/mne-python/pull/9969 and https://github.com/mne-tools/mne-python/pull/10019
not clearer yet :) do you want the info from the annotation as a column in the epoch *metadata* dataframe, or do you want those epochs to have "rest" as...
it's still not clear to me *how/where you want that information stored*. Do you want it in the `epochs.metadata` dataframe? Do you instead want it as a value in `epochs.event_id`?...
ah, gotcha. thanks for clarifying. I think the `epochs.metadata` approach will be most robust, and Adam is working on that as the next step after the `epochs.annotations` stuff (it's needed...
similar issues have come up before, see https://github.com/mne-tools/mne-python/issues/9221 and the fix (though apparently not enough of a fix?) in https://github.com/mne-tools/mne-python/pull/9227. cc @adswa in case she has some ideas here.
SGTM, go for it
1. move all rings to be inferior 2. it looks like the second example has devoicing rings on both segments? That's probably a mistake.