Dave Protasowski comments

Results 1317 comments of


                                            Dave Protasowski

WIP: just one option exploration for fixing #2115

Been dealing with the release and haven't had a chance to comment I think rather than baking in SupportedVerbs into our go types we allow API types to declare `OnCreate`...

[flakey] webhook.TestAdmissionInvalidResponseForResource

Here: https://github.com/knative/pkg/pull/2425 https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568

[flakey] webhook.TestAdmissionInvalidResponseForResource

/lifecycle frozen

Upgrading from to Knative Serving v1.2 shows "the manifests of the target version are not available to this release"

/assign @houshengbo

[flaky] TestMetricsExport is super flaky

/reopen `TestMetricsExport/OpenCensus` https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2189/pull-knative-pkg-unit-tests/1415384970213462016

[flaky] TestMetricsExport is super flaky

/lifecycle frozen

Supporting reading TLS data from places other than Kubernetes Secrets

/remove-lifecycle stale

Supporting reading TLS data from places other than Kubernetes Secrets

/lifecycle frozen

[webhook] logger in context should be annotated with webhook type

> Can you provide details on which type has logging in SetDefaults function? I was adding the logging myself while debugging something. That's where I noticed there are multiple calls...

[webhook] logger in context should be annotated with webhook type

/remove-lifecycle stale